Revert "bpo-38811: Check for presence of os.link method in pathlib" #17219
Conversation
|
The PR #17170 broke buildbot https://buildbot.python.org/all/#/builders/40/builds/3413 and it was merged whereas the CLA was not signed. |
|
So that means you'd rather I open a completely new pull request with the buildbot failure fixed, instead of a fix on top of current master? |
|
@vstinner: Please replace |
First of all, please sign the CLA: see the bot's explanation. I merged my revert, so in short you have to rewrite PR #17170. If possible, with a fix for the Windows 7 buildbot. By default, if a change breaks a buildbot and nobody fix the issue quickly, the change should be reverted. Here, it was also a licensing issue. |
|
Victor Stinner <notifications@github.com> writes:
> So that means you'd rather I open a completely new pull request with the buildbot failure fixed, instead of a fix on top of current master?
First of all, please sign the CLA: see the bot's explanation.
#17170 (comment)
Working on that...
I merged my revert, so in short you have to rewrite PR #17170.
OK, I'll open a new PR with a fixed version.
If possible, with a fix for the Windows 7 buildbot. By default, if a
change breaks a buildbot and nobody fix the issue quickly, the change
should be reverted.
Is there a way to get the buildbot to run on the PR before it's merged?
All the CI tests passed beforehand, and I don't have a Windows system to
test on myself...
…-Toke
|
Ping me once you're ready. I can help you on that. There is a way to run buildbots on a PR before it's merged. And I have a Windows 10 VM. But I don't think that I will be able to reproduce the issue on my Windows 10 VM. |
…ythonGH-17170)" (python#17219) This reverts commit 111772f.
…ythonGH-17170)" (python#17219) This reverts commit 111772f.
Reverts #17170
https://bugs.python.org/issue38811